Complement TemplateSpec140 to VMSpec140 #2403
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Albin Sun <albin.sun@suse.com>
irishgordo
approved these changes
Jan 15, 2026
Contributor
irishgordo
left a comment
irishgordo
left a comment
There was a problem hiding this comment.
looks good, lgtm - thanks @albinsun for cultivating the consistency across specs and fixing the failure 👍 💯 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Issue #2371
What this PR does / why we need it:
Why we need it
test_4_vm_template.py::TestVMTemplate::test_create_template_with_datafails due to theTemplateSpecclass is not inherited from correspondingVMSpec.Ref. [TEST] test_4_vm_template.py::TestVMTemplate::test_create_template_with_data fail due to TypeError #2371 (comment)
What this PR does
Add
TemplateManager140andTemplateSpec140inherited fromVMSpec140Verification
TemplateSpec140should has MRO[TemplateSpec140, TemplateSpec, VMSpec140, VMSpec]Test case PASS
