This repository was archived by the owner on Dec 6, 2023. It is now read-only.
Listen on both IPv4 and IPv6 by default#195
Open
jfroche wants to merge 1 commit intohashicorp:mainfrom
Open
Conversation
We use `-dev-listen-address` with 0.0.0.0 as default prefix. This means that Vault listener factory [1] bind only on IPv4. We would like to bind on both IPv4 and IPv6 by default. net.Listen [1] creates servers which can be bind on both IPv4 and IPv6 when we provide an empty host address such as ":8200". [1] https://github.com/hashicorp/vault/blob/15863772554cbea9a75e1146a152cd9fb112bb0f/command/server/listener_tcp.go#L27 [1] https://golang.org/pkg/net/#Listen
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We use
-dev-listen-addresswith 0.0.0.0 as default prefix.This means that Vault listener factory [1] bind only on IPv4.
We would like to bind on both IPv4 and IPv6 by default.
net.Listen [1] creates servers which can be bind on both IPv4 and
IPv6 when we provide an empty host address such as ":8200".
[1] https://github.com/hashicorp/vault/blob/15863772554cbea9a75e1146a152cd9fb112bb0f/command/server/listener_tcp.go#L27
[1] https://golang.org/pkg/net/#Listen