ci: add semgrep rules check in security-scanner plugins#25924
ci: add semgrep rules check in security-scanner plugins#25924dduzgun-security wants to merge 3 commits intomainfrom
Conversation
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
jrasell
left a comment
There was a problem hiding this comment.
LGTM, thanks @dduzgun-security!
Should we backport this to all our release branches as well?
|
@jrasell thanks for the review. I pushed a small fix for the path (so we don't scan the security-scanner itself) and also to include the plugins. This would indeed need some labels to be backported since we scan for active release/x.y.z branches too 👍 |
Description
Adding plugins for semgrep rules and adding codeql go scans on PR too (it's done through the scheduled/daily scan only currently) in the security scanner configuration.
Testing & Reproduction steps
Links
Contributor Checklist
changelog entry using the
make clcommand.ensure regressions will be caught.
and job configuration, please update the Nomad website documentation to reflect this. Refer to
the website README for docs guidelines. Please also consider whether the
change requires notes within the upgrade guide.
Reviewer Checklist
backporting document.
in the majority of situations. The main exceptions are long-lived feature branches or merges where
history should be preserved.
within the public repository.