build: upgrade to Go 1.25.1

[pkazmierczak]

No description provided.

[pkazmierczak]

Requires golang.org/x/tools upgrade in go-msgpack hashicorp/go-msgpack#35

[pkazmierczak]

Requires golang.org/x/tools upgrade in serf: hashicorp/serf#778

Actually not true. As it turns out, we can build with old serf.

[pkazmierczak]

I'm confused. make check fails to build dependencies due to:

# golang.org/x/tools/internal/tokeninternal
Error: ../../../go/pkg/mod/golang.org/x/tools@v0.14.0/internal/tokeninternal/tokeninternal.go:78:9: invalid array length -delta * delta (constant -256 of type int64)
make: *** [GNUmakefile:144: deps] Error 1

And at the same time, we don't seem to be pulling that as a dependency anywhere!

$ go mod graph | grep tools@v0.14.0
$ go mod graph | grep msgpack/v2@v2.1.2

return empty output.

[pkazmierczak]

An update on this: it's not just tools@v0.14.0 that we have to deal with, it's any version of this package until v0.26.0 (see golang/go#74462). So:

$ go mod why -m golang.org/x/tools
# golang.org/x/tools
github.com/hashicorp/nomad/command
github.com/hashicorp/hcl/v2
golang.org/x/tools/cmd/stringer

This means we need to upgrade hcl/v2 to use a more modern version of tools before we can get anywhere. cc @Juanadelacuesta

[tgross]

This means we need to upgrade hcl/v2 to use a more modern version of tools before we can get anywhere. cc @Juanadelacuesta

Also note that we have a Nomad-specific branch of HCL2

[pkazmierczak]

HCL v2 update draft: hashicorp/hcl#768

Actually not needed. As it turns out, we can build with old hcl.

[jrasell]

LGTM!

[github-actions]

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.