fix: Validate the existence of configured volume paths on an OS #27288
fix: Validate the existence of configured volume paths on an OS #27288AppCrashExpress wants to merge 8 commits intohashicorp:mainfrom
Conversation
|
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement Learn more about why HashiCorp requires a CLA and what the CLA includes Have you signed the CLA already but the status is still pending? Recheck it. |
command/agent/command_test.go
Outdated
| Path: dirPath, | ||
| }, | ||
| { | ||
| Name: "test", |
There was a problem hiding this comment.
Should we be able to set the same names here, really?
There was a problem hiding this comment.
@AppCrashExpress there is nothing stopping you setting the same string multiple times in table driven tests. That being said, the name "test" does not help identify the test being run here, so having a slightly more descriptive name would be good.
There was a problem hiding this comment.
Oh, no, I just thought that they must be unique in general. I have, however, changed the names of volumes just in case.
3de70b4 to
85e8fac
Compare
Description
This PR adds simple validation for existence of configured
host_volumepath on OS, wherenomad config validateis run.Testing & Reproduction steps
Without the fix, the validation of config:
Runs successfully whether the file exists or not:
With the patch, it results in an error:
Links
Fixes: #16968
Contributor Checklist
changelog entry using the
make clcommand.ensure regressions will be caught.
and job configuration, please update the Nomad product documentation, which is stored in the
web-unified-docsrepo. Refer to theweb-unified-docscontributor guide for docs guidelines.Please also consider whether the change requires notes within the upgrade
guide. If you would like help with the docs, tag the
nomad-docsteam in this PR.Reviewer Checklist
backporting document.
in the majority of situations. The main exceptions are long-lived feature branches or merges where
history should be preserved.
within the public repository.
Changes to Security Controls
There are no changes to security controls.