Update member info on serf EventMemberUpdate#27428
Open
marvinchin wants to merge 1 commit intohashicorp:mainfrom
Open
Update member info on serf EventMemberUpdate#27428marvinchin wants to merge 1 commit intohashicorp:mainfrom
marvinchin wants to merge 1 commit intohashicorp:mainfrom
Conversation
tgross
requested changes
Jan 28, 2026
Member
tgross
left a comment
There was a problem hiding this comment.
Hi @marvinchin! Thanks for the PR! A few things to address:
- When the server receives an event on this channel, we update the
peersCachewith the parsed parts. It looks like if we start acceptingEventMemberUpdatethat we end up with duplicate entries. So we'll need to de-duplicate those as well. - Testing is a little gross because we can't easily force the running agent to update and the
TestServercleans itself up on shutdown. We could probably have a test innomad/serf_test.gothat injects the event directly and that'll exercise things likepeersCache, but those changes won't show up in the memberlist. That's probably fine though, as that's what we care about here. - Can I get you to sign the CLA and work up a changelog via
make changelog?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix #27427
Testing & Reproduction steps
Repeated the reproduction in #27427 and verified that it now works.
Happy to add some automated tests if maintainers feel that it's necessary, please feel free to point me to where to add the tests if so.
Reviewer Checklist
backporting document.
in the majority of situations. The main exceptions are long-lived feature branches or merges where
history should be preserved.
within the public repository.
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.