Backport of services: update check IDs from group service hook on update into release/1.11.x#27476
Merged
tgross merged 1 commit intorelease/1.11.xfrom Feb 6, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #27466 to be assessed for backporting due to the inclusion of the label backport/1.11.x.
The below text is copied from the body of the original PR.
In #27453 we fixed a bug in script check hook interpolation by recording the check IDs for each check in the group service hook and then passing that to the script check hook via alloc hook resources. But this change did not account for checks being updated in-place, so the script check hook reads the old check IDs and fails. This was caught by nightly E2E testing.
Record the updated check IDs in the group service hook as well. Expand the group service tests to include updating the checks.
Ref: #27453
Ref: https://hashicorp.atlassian.net/browse/NMD-1054
Ref: https://github.com/hashicorp/nomad-e2e/actions/runs/21699934682/job/62586402991
Testing & Reproduction steps
In addition to the unit tests above, you can exercise this code with the jobs in the E2E test:
nomad job run ./checks_group.nomadnomad job run ./checks_group_update.nomadContributor Checklist
changelog entry using the
make clcommand.ensure regressions will be caught.
and job configuration, please update the Nomad product documentation, which is stored in the
web-unified-docsrepo. Refer to theweb-unified-docscontributor guide for docs guidelines.Please also consider whether the change requires notes within the upgrade
guide. If you would like help with the docs, tag the
nomad-docsteam in this PR.Reviewer Checklist
backporting document.
in the majority of situations. The main exceptions are long-lived feature branches or merges where
history should be preserved.
within the public repository.
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.
Overview of commits