s2 should see its status as alive after fixing issue #18#738
Open
mbver wants to merge 2 commits intohashicorp:masterfrom
Open
s2 should see its status as alive after fixing issue #18#738mbver wants to merge 2 commits intohashicorp:masterfrom
mbver wants to merge 2 commits intohashicorp:masterfrom
Conversation
skpratt
suggested changes
Aug 20, 2024
skpratt
left a comment
skpratt
left a comment
There was a problem hiding this comment.
Hi @mbver, if you could update the description to add more background detail for the expected state of s2's members, so it is clear what this test is covering, that would be great.
It also looks like the test as written in master is not currently failing. Could you please add a description for why the existing test to verify the state of s1's members should be removed? Rather than adding a separate check for s2?
Author
|
thanks @skpratt . test for s1 is added. |
skpratt
approved these changes
Aug 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the test doesn't reflect the fix of issue #18. before apply fixing, a node rejoins the cluster still sees itself in "leaving" state while other nodes see it as alive. now, it sees itself as alive.