Skip to content

[IND-4227][COMPLIANCE] chore: update build tags to modern format #781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ssagarverma merged 2 commits into from
Nov 25, 2025
+158 −69
Merged

[IND-4227][COMPLIANCE] chore: update build tags to modern format #781

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fedf402
chore: update build tags to modern format
ssagarverma Nov 10, 2025
96209da
chore: Upgrade golangci-lint config to v2
ssagarverma Nov 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
83 changes: 83 additions & 0 deletions .golangci.bck.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,83 @@
# Copyright (c) HashiCorp, Inc.
# SPDX-License-Identifier: MPL-2.0

linters:
disable-all: true
enable:
# (TODO) uncomment after fixing the lint issues
# - gofmt
- govet
# - unconvert
# - staticcheck
# - ineffassign
# - unparam
- forbidigo

issues:
# Disable the default exclude list so that all excludes are explicitly
# defined in this file.
exclude-use-default: false

exclude-rules:
# Temp Ignore SA9004: only the first constant in this group has an explicit type
# https://staticcheck.io/docs/checks#SA9004
- linters: [staticcheck]
text: 'SA9004:'

- linters: [staticcheck]
text: 'SA1019: Package github.com/golang/protobuf/jsonpb is deprecated'

- linters: [staticcheck]
text: 'SA1019: Package github.com/golang/protobuf/proto is deprecated'

- linters: [staticcheck]
text: 'SA1019: ptypes.MarshalAny is deprecated'

- linters: [staticcheck]
text: 'SA1019: ptypes.UnmarshalAny is deprecated'

- linters: [staticcheck]
text: 'SA1019: package github.com/golang/protobuf/ptypes is deprecated'

# An argument that always receives the same value is often not a problem.
- linters: [unparam]
text: 'always receives'

# Often functions will implement an interface that returns an error without
# needing to return an error. Sometimes the error return value is unnecessary
# but a linter can not tell the difference.
- linters: [unparam]
text: 'result \d+ \(error\) is always nil'

# Allow unused parameters to start with an underscore. Arguments with a name
# of '_' are already ignored.
# Ignoring longer names that start with underscore allow for better
# self-documentation than a single underscore by itself. Underscore arguments
# should generally only be used when a function is implementing an interface.
- linters: [unparam]
text: '`_[^`]*` is unused'

# Temp ignore some common unused parameters so that unparam can be added
# incrementally.
- linters: [unparam]
text: '`(t|resp|req|entMeta)` is unused'

linters-settings:
gofmt:
simplify: true
forbidigo:
# Forbid the following identifiers (list of regexp).
forbid:
- '\brequire\.New\b(# Use package-level functions with explicit TestingT)?'
- '\bassert\.New\b(# Use package-level functions with explicit TestingT)?'
- '\bmetrics\.IncrCounter\b(# Use labeled metrics)?'
- '\bmetrics\.AddSample\b(# Use labeled metrics)?'
- '\bmetrics\.MeasureSince\b(# Use labeled metrics)?'
- '\bmetrics\.SetGauge\b(# Use labeled metrics)?'
# Exclude godoc examples from forbidigo checks.
# Default: true
# exclude_godoc_examples: false

run:
timeout: 10m
concurrency: 4
142 changes: 75 additions & 67 deletions .golangci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,11 @@
# Copyright (c) HashiCorp, Inc.
# SPDX-License-Identifier: MPL-2.0

version: "2"
run:
concurrency: 4
linters:
disable-all: true
default: none
enable:
# (TODO) uncomment after fixing the lint issues
# - gofmt
Expand All @@ -13,71 +16,76 @@ linters:
# - unparam
- forbidigo

issues:
# Disable the default exclude list so that all excludes are explicitly
# defined in this file.
exclude-use-default: false

exclude-rules:
settings:
forbidigo:
# Forbid the following identifiers (list of regexp).
forbid:
- pattern: \brequire\.New\b(# Use package-level functions with explicit TestingT)?
- pattern: \bassert\.New\b(# Use package-level functions with explicit TestingT)?
- pattern: \bmetrics\.IncrCounter\b(# Use labeled metrics)?
- pattern: \bmetrics\.AddSample\b(# Use labeled metrics)?
- pattern: \bmetrics\.MeasureSince\b(# Use labeled metrics)?
- pattern: \bmetrics\.SetGauge\b(# Use labeled metrics)?
# Exclude godoc examples from forbidigo checks.
# Default: true
exclude-godoc-examples: false
exclusions:
generated: lax
rules:
# Temp Ignore SA9004: only the first constant in this group has an explicit type
# https://staticcheck.io/docs/checks#SA9004
- linters: [staticcheck]
text: 'SA9004:'

- linters: [staticcheck]
text: 'SA1019: Package github.com/golang/protobuf/jsonpb is deprecated'

- linters: [staticcheck]
text: 'SA1019: Package github.com/golang/protobuf/proto is deprecated'

- linters: [staticcheck]
text: 'SA1019: ptypes.MarshalAny is deprecated'

- linters: [staticcheck]
text: 'SA1019: ptypes.UnmarshalAny is deprecated'

- linters: [staticcheck]
text: 'SA1019: package github.com/golang/protobuf/ptypes is deprecated'

# An argument that always receives the same value is often not a problem.
- linters: [unparam]
text: 'always receives'

# Often functions will implement an interface that returns an error without
# needing to return an error. Sometimes the error return value is unnecessary
# but a linter can not tell the difference.
- linters: [unparam]
text: 'result \d+ \(error\) is always nil'

# Allow unused parameters to start with an underscore. Arguments with a name
# of '_' are already ignored.
# Ignoring longer names that start with underscore allow for better
# self-documentation than a single underscore by itself. Underscore arguments
# should generally only be used when a function is implementing an interface.
- linters: [unparam]
text: '`_[^`]*` is unused'

# Temp ignore some common unused parameters so that unparam can be added
# incrementally.
- linters: [unparam]
text: '`(t|resp|req|entMeta)` is unused'

linters-settings:
gofmt:
simplify: true
forbidigo:
# Forbid the following identifiers (list of regexp).
forbid:
- '\brequire\.New\b(# Use package-level functions with explicit TestingT)?'
- '\bassert\.New\b(# Use package-level functions with explicit TestingT)?'
- '\bmetrics\.IncrCounter\b(# Use labeled metrics)?'
- '\bmetrics\.AddSample\b(# Use labeled metrics)?'
- '\bmetrics\.MeasureSince\b(# Use labeled metrics)?'
- '\bmetrics\.SetGauge\b(# Use labeled metrics)?'
# Exclude godoc examples from forbidigo checks.
# Default: true
exclude_godoc_examples: false

run:
timeout: 10m
concurrency: 4
- linters:
- staticcheck
text: 'SA9004:'
- linters:
- staticcheck
text: 'SA1019: Package github.com/golang/protobuf/jsonpb is deprecated'
- linters:
- staticcheck
text: 'SA1019: Package github.com/golang/protobuf/proto is deprecated'
- linters:
- staticcheck
text: 'SA1019: ptypes.MarshalAny is deprecated'
- linters:
- staticcheck
text: 'SA1019: ptypes.UnmarshalAny is deprecated'
- linters:
- staticcheck
text: 'SA1019: package github.com/golang/protobuf/ptypes is deprecated'
# An argument that always receives the same value is often not a problem.
- linters:
- unparam
text: always receives
# Often functions will implement an interface that returns an error without
# needing to return an error. Sometimes the error return value is unnecessary
# but a linter can not tell the difference.
- linters:
- unparam
text: result \d+ \(error\) is always nil
# Allow unused parameters to start with an underscore. Arguments with a name
# of '_' are already ignored.
# Ignoring longer names that start with underscore allow for better
# self-documentation than a single underscore by itself. Underscore arguments
# should generally only be used when a function is implementing an interface.
- linters:
- unparam
text: '`_[^`]*` is unused'
# Temp ignore some common unused parameters so that unparam can be added
# incrementally.
- linters:
- unparam
text: '`(t|resp|req|entMeta)` is unused'
paths:
- third_party$
- builtin$
- examples$
formatters:
settings:
gofmt:
simplify: true
exclusions:
generated: lax
paths:
- third_party$
- builtin$
- examples$
1 change: 0 additions & 1 deletion serf/internal/race/race_disabled.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
// SPDX-License-Identifier: MPL-2.0

//go:build !race
// +build !race

package race

Expand Down
1 change: 0 additions & 1 deletion serf/internal/race/race_enabled.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
// SPDX-License-Identifier: MPL-2.0

//go:build race
// +build race

package race

Expand Down
Loading