Update dependencies to latest versions#79
Open
b0ralgin wants to merge 6 commits intohaskell-haskey:masterfrom
Open
Update dependencies to latest versions#79b0ralgin wants to merge 6 commits intohaskell-haskey:masterfrom
b0ralgin wants to merge 6 commits intohaskell-haskey:masterfrom
Conversation
Upgrade actions/cache from v2 to v3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Updates haskey to work with modern Haskell libraries, specifically upgrading from Stack LTS 9.0 (GHC 8.0.2) to LTS 22.44 (GHC 9.6.7). This includes fixing breaking API changes in unix-2.8.x and updating dependency bounds.
Where should the reviewer start?
Start by reviewing the main API change in src-unix/FileIO.hs - the openFd function signature changed in unix-2.8.x, removing the Maybe FileMode parameter and requiring file creation flags to be passed via OpenFileFlags. The changes ensure files are created with proper permissions when they don't exist.
How should this be manually tested?
- haskey-properties - property-based tests
- haskey-integration - integration tests including file backend tests
- haskey-example - example usage test
All tests pass successfully with the updated dependencies.
Any background context you want to provide?
The unix package underwent significant API changes in version 2.8.0, where openFd changed from:
openFd :: FilePath -> OpenMode -> Maybe FileMode -> OpenFileFlags -> IO Fd
to:
openFd :: FilePath -> OpenMode -> OpenFileFlags -> IO Fd
File creation mode is now specified via the creat field in OpenFileFlags. Additionally, many imports like Control.Applicative operators are now redundant as they're part of Prelude in modern GHC.
What are the relevant tickets?
None