Added CMake build process to the project#1
Open
richardlayman wants to merge 14 commits intoheeen:masterfrom
richardlayman:master
Open
Added CMake build process to the project#1richardlayman wants to merge 14 commits intoheeen:masterfrom richardlayman:master
richardlayman wants to merge 14 commits intoheeen:masterfrom
richardlayman:master
Conversation
| #include <qpa/qplatformnativeinterface.h> | ||
| //#include <qpa/qplatformnativeinterface.h> | ||
| // TODO - I need to fix this below line so that you can build using the above line | ||
| #include <QtGui/5.6.0/QtGui/qpa/qplatformnativeinterface.h> |
Owner
There was a problem hiding this comment.
sorry, I won't merge it if it ties the whole build to this qt version
There was a problem hiding this comment.
What do you need qplatformnativeinterface for?
Owner
There was a problem hiding this comment.
to get the xcb handle: https://github.com/heeen/qtvulkan/blob/master/cube/qvulkanview.cpp#L1182
Owner
|
Hi, Florian |
…modified the README
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I made a few changes that would effect the qmake build.
I changed the location of the qpa header which I need to fix.
I also changed the location of the shaders search path - which really isn't needed, it was just put there for aesthetics.