POWER 4446 Fix refresh token logic #77
Conversation
|
By removing the injection of Let's discuss 🤓 |
| _tokenExpiresOn = accessTokenProvider.GetTokenExpiry(); | ||
| foreach (var header in accessTokenProvider.GetAccessHeaders()) | ||
| { | ||
| HttpClient.DefaultRequestHeaders.TryAddWithoutValidation(header.Key, header.Value); |
There was a problem hiding this comment.
Instead of creating a separate auth handler and removing existing functionality as previously mentioned here, I would suggest the following:
Keep HeimdallApiHttpClient as is, and add a check that if HttpClient.DefaultRequestHeaders already contains the header.key, then remove it first and then add the KeyValue pair as we are already doing here HttpClient.DefaultRequestHeaders.TryAddWithoutValidation(header.Key, header.Value.
There was a problem hiding this comment.
The issue here is that HttpClient.DefaultRequestHeaders is not a dictionary as one could expect, but rather a key with an associated array. That means that when we add a new value, it is appended instead of overwriting the existing value and after some time the header becomes to big, overflows and then the request fails.
|
Closing this PR, might come back to this solution later |
This PR fixes the refresh token logic, assuring old tokens doesn't accumulate in the header.