Fix WASM exports handling and add validation for Harfbuzz exports in icons-subsetter#25
Open
cto-new[bot] wants to merge 2 commits intodevelopfrom
Open
Fix WASM exports handling and add validation for Harfbuzz exports in icons-subsetter#25cto-new[bot] wants to merge 2 commits intodevelopfrom
cto-new[bot] wants to merge 2 commits intodevelopfrom
Conversation
…uzz exports validation
Fixes a bug where direct WASM export references could fail due to improper instantiation structure. Now destructures `{ instance }` from `WebAssembly.instantiate` and references `instance.exports` with defensive export checks.
- Instantiates WASM using destructuring to access exports from `instance.exports`
- Adds validation for required Harfbuzz exports, including `memory`
- Raises clear initialization errors if required exports are missing
- Maintains type safety by guarding assignments
This prevents runtime errors such as missing `memory` exports and gives clearer initialization failures for debugging.
Add missing SPDX-FileCopyrightText and SPDX-License-Identifier headers to the backend migration file 1690280117923-instance-silence.js to comply with license policy checks.
|
Thank you for sending us a great Pull Request! 👍 example: pnpm run build-misskey-js-with-types |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ensures compliance with project license requirements by adding missing SPDX headers to a backend migration file. The project builds and passes license checks as expected.
Details
Warning: Task VM test is not passing, cto.new will perform much better if you fix the setup