-
Notifications
You must be signed in to change notification settings - Fork 92
Add support for Delinea Secret Server #916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
921047a to
182d9ae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds support for Delinea Secret Server as a new provider in vals, enabling users to fetch secrets from Delinea's REST API using the ref+secretserver:// URI scheme.
Key Changes:
- Implements new secretserver provider with support for retrieving individual secret fields and full secret maps
- Integrates provider into vals core runtime and string provider system
- Adds documentation for configuration and usage patterns
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 10 comments.
| File | Description |
|---|---|
| vals.go | Registers the secretserver provider constant and factory in the runtime's provider preparation logic |
| pkg/stringprovider/stringprovider.go | Adds secretserver case to the string provider factory for provider instantiation |
| pkg/providers/secretserver/secretserver.go | Implements the new provider with HTTP client, authentication, and secret retrieval methods |
| README.md | Documents the secretserver provider with environment variables and usage examples |
02a117f to
ab4d732
Compare
|
Applied the copilot changes and moved the URL from the ref url to an environment variable, to prevent exfiltration of the access token. My code was essentially just a copy of the gitlab provider. Some of the Issues raised by copilot are present there as well. |
c032321 to
c461ffb
Compare
Signed-off-by: Dargel, Philipp <philipp.dargel@governikus.de>
c461ffb to
1718ecc
Compare
|
fixed lint issue and rebased. |
Add support for Delinea SecretSevers using their REST API.
This was tested against a private Instance. I don't know if there is a public demo app to test against.