Skip to content

Conversation

@pd-gov
Copy link

@pd-gov pd-gov commented Dec 23, 2025

Add support for Delinea SecretSevers using their REST API.

This was tested against a private Instance. I don't know if there is a public demo app to test against.

@pd-gov pd-gov force-pushed the feature/secretserver branch 5 times, most recently from 921047a to 182d9ae Compare December 24, 2025 17:00
@yxxhero yxxhero requested a review from Copilot December 25, 2025 00:44
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for Delinea Secret Server as a new provider in vals, enabling users to fetch secrets from Delinea's REST API using the ref+secretserver:// URI scheme.

Key Changes:

  • Implements new secretserver provider with support for retrieving individual secret fields and full secret maps
  • Integrates provider into vals core runtime and string provider system
  • Adds documentation for configuration and usage patterns

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 10 comments.

File Description
vals.go Registers the secretserver provider constant and factory in the runtime's provider preparation logic
pkg/stringprovider/stringprovider.go Adds secretserver case to the string provider factory for provider instantiation
pkg/providers/secretserver/secretserver.go Implements the new provider with HTTP client, authentication, and secret retrieval methods
README.md Documents the secretserver provider with environment variables and usage examples

@pd-gov pd-gov force-pushed the feature/secretserver branch 3 times, most recently from 02a117f to ab4d732 Compare December 25, 2025 12:32
@pd-gov
Copy link
Author

pd-gov commented Dec 25, 2025

Applied the copilot changes and moved the URL from the ref url to an environment variable, to prevent exfiltration of the access token.

My code was essentially just a copy of the gitlab provider. Some of the Issues raised by copilot are present there as well.

@pd-gov pd-gov force-pushed the feature/secretserver branch 2 times, most recently from c032321 to c461ffb Compare December 26, 2025 10:28
Signed-off-by: Dargel, Philipp <philipp.dargel@governikus.de>
@pd-gov pd-gov force-pushed the feature/secretserver branch from c461ffb to 1718ecc Compare December 26, 2025 10:29
@pd-gov
Copy link
Author

pd-gov commented Dec 26, 2025

fixed lint issue and rebased.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant