Fix for changes in urlsplit #14
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urlsplit function was changed to strip ASCII newline and tab characters in python/cpython#25595. The change causes this plugin to not properly authenticate with S3, since a required newline character is no longer present. This issue was identified on Amazon Linux 2 Python distribution which backported the change to Python 2. https://alas.aws.amazon.com/AL2/ALAS-2022-1802.html. urlsplit behaviour before the fix. ``` Python 2.7.18 (default, Jun 10 2021, 00:11:02) [GCC 7.3.1 20180712 (Red Hat 7.3.1-13)] on linux2 Type "help", "copyright", "credits" or "license" for more information. >>> from urlparse import urlsplit >>> urlsplit("http://localhost/some-path\n").path '/some-path\n' >>> ``` urlsplit behaviour after the fix. ``` Python 2.7.18 (default, May 25 2022, 14:30:51) [GCC 7.3.1 20180712 (Red Hat 7.3.1-15)] on linux2 Type "help", "copyright", "credits" or "license" for more information. >>> from urlparse import urlsplit >>> urlsplit("http://localhost/some-path\n").path '/some-path' >>> ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
urlsplit function was changed to strip ASCII newline and tab characters
in python/cpython#25595.
The change causes this plugin to not properly authenticate with S3, since
a required newline character is no longer present.
This issue was identified on Amazon Linux 2 Python distribution which
backported the change to Python 2.
https://alas.aws.amazon.com/AL2/ALAS-2022-1802.html.
PR #13 has a similar fix for this issue.
urlsplit behaviour before the fix.
urlsplit behaviour after the fix.