Skip to content

required changes done#285

Open
05hiteshbansal wants to merge 1 commit intohereisSwapnil:mainfrom
05hiteshbansal:main
Open

required changes done#285
05hiteshbansal wants to merge 1 commit intohereisSwapnil:mainfrom
05hiteshbansal:main

Conversation

@05hiteshbansal
Copy link

@05hiteshbansal 05hiteshbansal commented Jun 23, 2024

Description

The main problem was in User Context .jsx as it is blocking the user to not visit any page without token thus I have changed the condition to also allow user without token to visit if they are visiting login and register page

Resolves: #277

Checklist

Before submitting this pull request, kindly verify that the ensuing checkpoints have been reached.

  • Have you adhered to the repository's defined coding convention rules?
  • Have you updated the 'documentation.md' file with the method/function documentation?
  • Have you sent a message along with the result or response?
  • Have you used the try-catch technique?
  • Has the method/class been added to the documentation (md file)?

Screenshots

image

Additional Notes/Comments

Any additional remarks or suggestions concerning this pull request are welcome.


I certify that I have carried out the relevant checks and provided the requisite screenshot for validation by submitting this pull request.
I appreciate your contribution.

@vercel
Copy link

vercel bot commented Jun 23, 2024

@05hiteshbansal is attempting to deploy a commit to the swapnilsingh99's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @05hiteshbansal! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project.

We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

@05hiteshbansal
Copy link
Author

also please make it a level 2 problem as i have to really dig deep into the problem and realising the solution .

@05hiteshbansal
Copy link
Author

@hereisSwapnil please review my PR.

1 similar comment
@05hiteshbansal
Copy link
Author

@hereisSwapnil please review my PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUG:Sign up page is redirecting user to sign in

1 participant