Use std::optional if available instead of boost::optional - part one #1623
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asopov-here
force-pushed
the
NLAM-23-std-optional
branch
2 times, most recently
from
f5c4320 to
f13d510
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #1623 +/- ##
==========================================
- Coverage 80.26% 80.26% -0.00%
==========================================
Files 348 349 +1
Lines 13932 13937 +5
Branches 1489 1492 +3
==========================================
+ Hits 11182 11186 +4
- Misses 2149 2151 +2
+ Partials 601 600 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
asopov-here
force-pushed
the
NLAM-23-std-optional
branch
5 times, most recently
from
1ed5783 to
c998b4e
Compare
asopov-here
force-pushed
the
NLAM-23-std-optional
branch
from
c998b4e to
0155340
Compare
asopov-here
changed the title
asopov-here
force-pushed
the
NLAM-23-std-optional
branch
from
0155340 to
8ce079c
Compare
asopov-here
force-pushed
the
NLAM-23-std-optional
branch
2 times, most recently
from
c7d1812 to
0df5afb
Compare
andrey-kashcheev
previously approved these changes
Aug 6, 2025
mykolamalik
changed the title
mykolamalik
requested changes
Aug 6, 2025
asopov-here
force-pushed
the
NLAM-23-std-optional
branch
from
0df5afb to
d26c701
Compare
mykolamalik
previously approved these changes
Aug 7, 2025
andrey-kashcheev
previously approved these changes
Aug 7, 2025
asopov-here
dismissed stale reviews from andrey-kashcheev and mykolamalik
via
1f899bb
Currently, SDK requires C++11 minimum. So, boost::optional type is used for optional values. For C++17 and above more convenient is to use std::optional instead. The task NLAM-23 is about making this type configurable. This commit is a first part of the task: olp-cpp-sdk-core. Relates-To: NLAM-23 Signed-off-by: sopov <ext-alexander.sopov@here.com>
asopov-here
force-pushed
the
NLAM-23-std-optional
branch
from
1f899bb to
e63d6ec
Compare
andrey-kashcheev
approved these changes
Aug 7, 2025
mykolamalik
approved these changes
Aug 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, SDK requires C++11 minimum.
So, boost::optional type is used for optional values.
For C++17 and above more convenient is to use std::optional instead.
The task NLAM-23 is about making this type configurable.
This PR is a first part of the task: olp-cpp-sdk-core.
Relates-To: NLAM-23