Skip to content

Conversation

@asopov-here
Copy link
Contributor

Currently, SDK requires C++11 minimum.
So, boost::optional type is used for optional values. For C++17 and above more convenient is to use std::optional instead. The task NLAM-23 is about making this type configurable. This commit is a second part of the task: olp-cpp-sdk-authentication.

Relates-To: NLAM-23

@codecov
Copy link

codecov bot commented Aug 7, 2025

Codecov Report

❌ Patch coverage is 94.87179% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.29%. Comparing base (a387a38) to head (fef9e8d).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...k-authentication/src/AuthenticationClientUtils.cpp 66.67% 1 Missing ⚠️
olp-cpp-sdk-authentication/src/TokenResult.cpp 66.67% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1625      +/-   ##
==========================================
- Coverage   80.30%   80.29%   -0.02%     
==========================================
  Files         349      349              
  Lines       13937    13940       +3     
  Branches     1491     1492       +1     
==========================================
  Hits        11192    11192              
- Misses       2146     2150       +4     
+ Partials      599      598       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@asopov-here asopov-here marked this pull request as ready for review August 7, 2025 11:53
@asopov-here asopov-here force-pushed the NLAM-23-std-optional branch 4 times, most recently from 6379075 to 302a333 Compare August 8, 2025 07:10
Currently, SDK requires C++11 minimum.
So, boost::optional type is used for optional values.
For C++17 and above more convenient is to use std::optional instead.
The task NLAM-23 is about making this type configurable.
This commit is a second part of the task: olp-cpp-sdk-authentication.

Relates-To: NLAM-23
Signed-off-by: sopov <ext-alexander.sopov@here.com>
@asopov-here asopov-here merged commit cbf2c46 into master Aug 8, 2025
25 checks passed
@asopov-here asopov-here deleted the NLAM-23-std-optional branch August 8, 2025 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants