Skip to content

Conversation

@asopov-here
Copy link
Contributor

Currently, SDK requires C++11 minimum.
So, boost::optional type is used for optional values. For C++17 and above more convenient is to use std::optional instead. The task NLAM-23 is about making this type configurable. This commit is a second part of the task: olp-cpp-sdk-write.

Relates-To: NLAM-23

Currently, SDK requires C++11 minimum.
So, boost::optional type is used for optional values.
For C++17 and above more convenient is to use std::optional instead.
The task NLAM-23 is about making this type configurable.
This commit is a second part of the task: olp-cpp-sdk-write.

Relates-To: NLAM-23
Signed-off-by: sopov <ext-alexander.sopov@here.com>
@asopov-here asopov-here force-pushed the NLAM-23-std-optional branch from 00ba6c9 to 95a7eb4 Compare August 8, 2025 07:46
@codecov
Copy link

codecov bot commented Aug 8, 2025

Codecov Report

❌ Patch coverage is 45.90164% with 99 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.29%. Comparing base (cbf2c46) to head (c555d6f).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...-dataservice-write/src/VolatileLayerClientImpl.cpp 20.00% 16 Missing ⚠️
...dk-dataservice-write/src/generated/MetadataApi.cpp 0.00% 13 Missing ⚠️
...dataservice-write/src/VersionedLayerClientImpl.cpp 29.41% 12 Missing ⚠️
...p-sdk-dataservice-write/src/generated/QueryApi.cpp 10.00% 9 Missing ⚠️
...-sdk-dataservice-write/src/generated/IngestApi.cpp 38.46% 8 Missing ⚠️
...sdk-dataservice-write/src/generated/PublishApi.cpp 0.00% 8 Missing ⚠️
...-sdk-dataservice-write/src/generated/ConfigApi.cpp 30.00% 7 Missing ⚠️
...p-sdk-dataservice-write/src/generated/IndexApi.cpp 0.00% 5 Missing ⚠️
...erated/serializer/UpdateIndexRequestSerializer.cpp 0.00% 5 Missing ⚠️
...pp-sdk-dataservice-write/src/generated/BlobApi.cpp 33.33% 4 Missing ⚠️
... and 5 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1626      +/-   ##
==========================================
- Coverage   80.29%   80.29%   -0.00%     
==========================================
  Files         349      349              
  Lines       13941    13944       +3     
  Branches     1492     1491       -1     
==========================================
+ Hits        11193    11195       +2     
- Misses       2148     2150       +2     
+ Partials      600      599       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@asopov-here asopov-here marked this pull request as ready for review August 8, 2025 08:02
@rustam-gamidov-here
Copy link
Collaborator

it make sense to give PR's name depending on the content, not very hard but will make it easier to find something in future

Currently, SDK requires C++11 minimum.
So, boost::optional type is used for optional values.
For C++17 and above more convenient is to use std::optional instead.
The task NLAM-23 is about making this type configurable.
This commit is a second part of the task: olp-cpp-sdk-write.

Relates-To: NLAM-23
Signed-off-by: sopov <ext-alexander.sopov@here.com>
@asopov-here asopov-here changed the title Use std::optional if available. Use porting::optional in olp-cpp-sdk-write instead of boost::optional. Aug 8, 2025
@asopov-here asopov-here merged commit a03183a into master Aug 8, 2025
24 of 25 checks passed
@asopov-here asopov-here deleted the NLAM-23-std-optional branch August 8, 2025 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants