Add censor API to Log #1639
Merged
Add censor API to Log #1639
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustam-gamidov-here
force-pushed
the
rga/censor-log-message
branch
from
0338233 to
fb8b524
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1639 +/- ##
==========================================
- Coverage 80.33% 80.26% -0.08%
==========================================
Files 349 349
Lines 13952 14014 +62
Branches 1492 1511 +19
==========================================
+ Hits 11208 11247 +39
- Misses 2146 2155 +9
- Partials 598 612 +14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rustam-gamidov-here
force-pushed
the
rga/censor-log-message
branch
2 times, most recently
from
783c8ea to
21a94fc
Compare
It allows to set values to be masked from the log messages at runtime Relates-To: NLAM-140 Signed-off-by: Rustam Gamidov <ext-rustam.gamidov@here.com>
Codecov prefers to have patch config to be not lower than the rest of repository. The file has not been formatted properly before so there are changes not related to the censoring Relates-To: NLAM-140 Signed-off-by: Rustam Gamidov <ext-rustam.gamidov@here.com>
rustam-gamidov-here
force-pushed
the
rga/censor-log-message
branch
from
21a94fc to
b09408c
Compare
rustam-gamidov-here
requested review from
Hsilgos,
andrey-kashcheev and
mykolamalik
There are secrets that can be updated with time and it make sense not to censor them anymore not to let performance suffer. Relates-To: NLAM-140 Signed-off-by: Rustam Gamidov <ext-rustam.gamidov@here.com>
rustam-gamidov-here
force-pushed
the
rga/censor-log-message
branch
from
81962dc to
f3e3968
Compare
andrey-kashcheev
approved these changes
Nov 5, 2025
mykolamalik
approved these changes
Nov 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It allows to set values to be masked from the log messages at runtime
Relates-To: NLAM-140