Event Leaderboards 2.0 config and protocol updates. #144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements Event Leaderboards 2.0 by adding configuration and protocol support for enhanced event leaderboard features, including roll management, score targets, cooldowns, and tier progression controls.
Changes:
- Added roll tracking and limits with configurable reroll behavior and cooldown periods
- Introduced score targets with player caps and time limits for competitive constraints
- Added tier progression controls with per-phase delta configuration
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| hiro.proto | Extended protocol messages with new fields for rolls, score targets, cooldowns, and reroll freeze options across EventLeaderboard, EventLeaderboardRewardTier, EventLeaderboardChangeZone, and TeamEventLeaderboard |
| event_leaderboards.go | Added corresponding configuration structures and error definitions to support the new event leaderboard features |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| int64 score_target = 30; | ||
| // Number of players that can reach the score target, if one is defined. | ||
| int64 score_target_players = 31; | ||
| // Amount of time singe rolling into the cohort that participants have to submit scores. |
There was a problem hiding this comment.
Corrected spelling of 'singe' to 'since'.
Suggested change
| // Amount of time singe rolling into the cohort that participants have to submit scores. | |
| // Amount of time since rolling into the cohort that participants have to submit scores. |
| int64 score_target = 31; | ||
| // Number of players that can reach the score target, if one is defined. | ||
| int64 score_target_players = 32; | ||
| // Amount of time singe rolling into the cohort that participants have to submit scores. |
There was a problem hiding this comment.
Corrected spelling of 'singe' to 'since'.
Suggested change
| // Amount of time singe rolling into the cohort that participants have to submit scores. | |
| // Amount of time since rolling into the cohort that participants have to submit scores. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.