feat: migrate to color.addon from @heroku/heroku-cli-util #3470
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Migrates all add-on name and plan references to use the new semantic color.addon() function from @heroku/heroku-cli-util instead of generic colors like color.yellow() or color.green(). Changes: - Updated 8 files: 5 commands in addons/, 1 in apps/, 1 in drains/, 1 lib file - Changed all imports from @heroku-cli/color to @heroku/heroku-cli-util - Updated color.cmd() to color.command() where affected by import changes - Migrated addon names, addon plans, and addon service names to color.addon() - Kept config var colors as color.green() (out of scope for this PR) The new color.addon() function provides consistent bold yellow formatting for add-on names and plans throughout the CLI. Part of the color system migration plan (PR 3 of 17).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Migrates all add-on name and plan references to use the new semantic
color.addon()function from@heroku/heroku-cli-utilinstead of generic colors likecolor.yellow()orcolor.green().This is PR 3 of 17 in the color system migration plan, focusing on adopting the semantic color for add-ons as outlined in the migration plan document.
Changes Made
commands/addons/, 1 incommands/apps/, 1 incommands/drains/, and 3 lib files@heroku-cli/colorto@heroku/heroku-cli-utilin affected filescolor.cmd()tocolor.command()where affected by import changescolor.addon()color.green()(out of scope - will be handled separately)The new
color.addon()function provides consistent bold yellow formatting for add-on names and plans throughout the CLI.Type of Change
Breaking Changes (major semver update)
!after your change type to denote a change that breaks current behaviorFeature Additions (minor semver update)
Patch Updates (patch semver update)
Testing
Notes:
Steps:
./bin/run addons:create <service:plan>- verify addon name displays with bold yellow./bin/run addons:destroy <addon>- verify addon name in error messages./bin/run addons:wait <addon>- verify "Created " output uses new color./bin/run drains- verify addon drains display with proper colorsScreenshots (if applicable)
N/A - Terminal color output changes
Related Issues
Part of the color system migration plan -- https://gus.lightning.force.com/lightning/r/ADM_Work__c/a07EE00002T2hvTYAR/view