Changed how passwords are generated and persisted#543
Open
pacohope wants to merge 1 commit intohexparrot:masterfrom
Open
Changed how passwords are generated and persisted#543pacohope wants to merge 1 commit intohexparrot:masterfrom
pacohope wants to merge 1 commit intohexparrot:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are a few bugs in the lines that deal with user password. One could argue that the line that calls
chpasswdis the primary bug: it always runs, whether we have just generated the password or not. Rather than make a big messy pull request that changes the order of a bunch of things in the file, I just make the initial password determination logic more careful. So we can run thechpasswdcommand every time the container starts and it will do the right thing.incorrect behaviours
Password set to: xyzinto the file/root/password. Seems like it should writexyzand nothing else./root/passwordfile exists, the variableUSER_PASSWORDis NOT set to the file's contents. So later, when thechpasswdcommand runs, the password is clobberedthis update
This update makes things a bit clearer on password handling.
/root/passwordA couple other small fixes: I just use
$RANDOMa few times for the password. I also usedteein the pipeline to write it to/root/passwordin one simple motion.