Skip to content
This repository was archived by the owner on Jan 15, 2020. It is now read-only.

Conversation

@khorsky
Copy link

@khorsky khorsky commented Aug 29, 2018

I'm getting this notice, so it looks like the presumption the variable exists is wrong...

I would resend this PR into official stream too, but it looks abandoned. And I'm using your hfig/MAPI, so I'd like to have it fixed...

update:
I'm confused by this notice found in log. $GLOBALS should always exist, while it is one of the PHP predefined variables. I'm getting this error only in tests. If I try to test existence of the variable with isset($GLOBALS), it exists.

It's kind of strange.

@hfig
Copy link
Owner

hfig commented Oct 1, 2018

PHP doesn't initialise $GLOBALS until referenced, so maybe your test harness/framework is analysing the symbols table and throwing the notice rather than PHP itself??

@khorsky
Copy link
Author

khorsky commented Oct 1, 2018

Honestly, I've no idea. I'm using PHPUnit 7.3.2 with convertNoticesToExceptions="true". All tests are green, I just get notices in error.log.

I'm not sure if I would get "PHP Notice: Undefined variable: GLOBALS in <path-to-project>\vendor\hfig\pear-ole\OLE\ChainedBlockStream.php on line 147" if test framework would be the source of the notice.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants