This repository was archived by the owner on Feb 27, 2024. It is now read-only.
Fixed Access violation with 64 bit compilers and updated ifdefs#20
Open
csm101 wants to merge 1 commit intohgourvest:masterfrom
Open
Fixed Access violation with 64 bit compilers and updated ifdefs#20csm101 wants to merge 1 commit intohgourvest:masterfrom
csm101 wants to merge 1 commit intohgourvest:masterfrom
Conversation
…most recent delphi versions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DynArraySetLength expects a poiner to a Nativeint variable, which is 8 bytes when compiling for 64 bits, but code was passing a pointer to a 32 bit integer. this caused random access violations.
I also updated the ifdefs to take care of delphi versions > XE7