Fix examples compilation issue #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes compilation issues in examples that occurred after adding perfect forwarding functionality. The changes ensure examples compile correctly and extends CI to build examples and test across multiple C++ versions and compilers.
- Modified example files to use variables instead of literal values for function calls
- Extended CI to build examples and test on C++14, 20, and 23 with gcc/clang across Windows, Linux, and macOS
- Added compiler setup steps for Linux/macOS platforms
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| examples/no_macro.cpp | Replaced literal values with variables in function calls and added scope blocks |
| examples/access_function.cpp | Replaced literal values with variables in function calls |
| .github/workflows/ci_pipeline.yml | Extended CI matrix to test multiple C++ standards and compilers, added example building |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
hliberacki
force-pushed
the
fix_examples
branch
4 times, most recently
from
37d4d0f to
42e9a8d
Compare
hliberacki
force-pushed
the
fix_examples
branch
from
42e9a8d to
b86cb2e
Compare
hliberacki
force-pushed
the
fix_examples
branch
from
b86cb2e to
fe6738e
Compare
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
After adding perfect forwarding - some examples where not updated that made them crash - Extend CI to build examples Extended CI job to build examples - Extend CI to test on various C++ version CI now build the code using C++ [14, 20, 23], using [gcc, clang, msvc] running on Windows, Linux, MacOS
hliberacki
force-pushed
the
fix_examples
branch
from
fe6738e to
8199878
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After adding perfect forwarding - some examples where not updated that made them crash
Extended CI job to build examples
CI now build the code using C++ [14, 20, 23], using [gcc, clang, msvc] running on Windows, Linux, MacOS