this code adds support for structured ADIs#14
Open
BerndWernerGuenther wants to merge 2 commits intohms-networks:mainfrom
Open
this code adds support for structured ADIs#14BerndWernerGuenther wants to merge 2 commits intohms-networks:mainfrom
BerndWernerGuenther wants to merge 2 commits intohms-networks:mainfrom
Conversation
alkhms101
requested changes
Feb 4, 2026
Contributor
alkhms101
left a comment
alkhms101
left a comment
There was a problem hiding this comment.
I have commented on some formalities in the first review run. I haven't tested the code yet.
| #include "abcc_api.h" | ||
|
|
||
|
|
||
| //added to support structured ADIs; start |
Contributor
There was a problem hiding this comment.
Please avoid one line comments
| /* Index: 2 */ { "Element03", ABP_PAD7, 1, ADI_DESCR_ALL_ACCESS, 1, { { NULL, NULL } } }, /* 7 bits padding is needed starting at position 1 in struct2.bBitData[ 1 ] */ | ||
| /* Index: 3 */ { "Element04", ABP_UINT16, 1, AD_ADI_DESC____SG, 0, { { &struct2.iData, NULL } } } /* 16 bit type must at least be on a 8 bit aligned position */ | ||
| }; | ||
| //added to support structured ADIs; end |
Contributor
There was a problem hiding this comment.
Please avoid one line comments
| **------------------------------------------------------------------------------ | ||
| */ | ||
| const AD_AdiEntryType ABCC_API_asAdiEntryList[] = | ||
| //const AD_AdiEntryType AD_asADIEntryList[] = |
Contributor
There was a problem hiding this comment.
Please avoid one line comments
| **------------------------------------------------------------------------------ | ||
| */ | ||
| const AD_MapType ABCC_API_asAdObjDefaultMap[] = | ||
| //AD_MapType sDefaultMap[] = |
Contributor
There was a problem hiding this comment.
Please delete, references to older versions unnecessary
| **------------------------------------------------------------------------------ | ||
| */ | ||
| /* | ||
| ** The content of struct1 is described by ABCC_API_AdiStruct1 below |
Contributor
There was a problem hiding this comment.
Avoid pointing out the obvious...
| } struct1; | ||
|
|
||
| /* | ||
| ** The content of struct2 is described by ABCC_API_AdiStruct2 below |
Contributor
There was a problem hiding this comment.
Avoid pointing out the obvious...
| #include "abcc_types.h" | ||
| #include "abp.h" | ||
|
|
||
| //added to support structured ADIs; start |
Contributor
There was a problem hiding this comment.
Please avoid one line comments
| #define ABCC_CFG_STRUCT_DATA_TYPE_ENABLED 1 | ||
| #endif | ||
| #endif | ||
| //added to support structured ADIs; end |
Contributor
There was a problem hiding this comment.
Please avoid one line comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added code for selecting structured ADIs instead of the speed-refspeed-example of the starterkit code;
the structured ADIs had already been defined in the header file abcc_interface_data_interface.h of abcc_driver\inc.
I added
_**//added to support structured ADIs; start
#ifndef ABCC_CFG_DRV_STRUCTURED_ADIS
#define ABCC_CFG_DRV_STRUCTURED_ADIS 1
#endif
#ifdef ABCC_CFG_DRV_STRUCTURED_ADIS
#ifndef ABCC_CFG_STRUCT_DATA_TYPE_ENABLED
#define ABCC_CFG_STRUCT_DATA_TYPE_ENABLED 1
#endif
#endif
//added to support structured ADIs; end**_
inside the file abcc_driver_config.h.
These 2 compiler switches will be used inside the code to switch between the structured ADI version and the Speed / Refspeed version.