FEAT]: Endpoint to Implement Edit or Update of Comments#1199
Open
BlessOnyi wants to merge 6 commits intohngprojects:devfrom
Open
FEAT]: Endpoint to Implement Edit or Update of Comments#1199BlessOnyi wants to merge 6 commits intohngprojects:devfrom
BlessOnyi wants to merge 6 commits intohngprojects:devfrom
Conversation
Contributor
|
Resolve conflict |
Contributor
|
Commit messages not compliant |
samuelogboye
requested changes
Mar 1, 2025
Comment on lines
+145
to
+148
|
|
||
|
|
||
|
|
||
|
|
Contributor
There was a problem hiding this comment.
Reduce this space here.
Comment on lines
+61
to
+77
|
|
||
| def update_comments(self, db: Session, id: str, content: str): | ||
| """Updates a comment""" | ||
|
|
||
| comment = self.fetch(db=db, id=id) | ||
| # Update the fields with the provided schema data | ||
| if comment is None: | ||
| return None | ||
|
|
||
| # Update the comment's content field | ||
| comment.content = content | ||
|
|
||
| # Commit the changes to the database | ||
| db.commit() | ||
| db.refresh(comment) | ||
|
|
||
| return comment |
Contributor
There was a problem hiding this comment.
The update_comments method in the service layer is very similar to the existing update method. Consider consolidating them or reusing the update method.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[FEAT]: Endpoint to Implement Edit or Update of Comments #1046
Description
This PR implements an endpoint that allows authenticated users to update their comments.
Acceptance Criteria
/api/v1/comments/{id}Purpose
To allow users to update their own comments while ensuring proper access control and security.
Requirements
Expected Outcome
Tasks
PATCHendpoint/api/v1/comments/{id}to edit a comment.Example Requests [With Auth Token]
PATCH Request:
curl -X PATCH {rootdomain}/api/v1/comments/{id} \ -H "Authorization: Bearer YOUR_ACCESS_TOKEN" \ -H "Content-Type: application/json" \ -d '{ "content": "Updated comment text" }'Response (Success):
{ "status_code": 200, "message": "Comment updated successfully", "comment_id": "123", "new_content": "Updated comment text" }Response (Error - Comment Not Found):
{ "status_code": 404, "message": "Comment not found." }Response (Error - Forbidden: No Permission to Edit):
{ "status_code": 403, "message": "You do not have permission to edit this comment." }Response (Error - Unauthorized Access: Missing or Invalid Token):
{ "status_code": 401, "message": "Not authorized." }Testing