Open
Conversation
also: - use named variables - more (and modernized) quoting - strip trailing whitespace - consistent indentation
Collaborator
Author
|
some more ideas for improving the test-scripts:
i can implement both if you want me to. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
use the same interface for all test wrappers (
tests/*.sh):<scriptname> <testfile-without-extension> [<mysofa2json>]improve argument check, and print usage information if the test-scripts are called with the wrong args
consistent indentation and removed trailing whitespace
pass the path to
mysofa2jsonto thetests/nocrash.shscript as well (like for the other wrappers)Related: v1.3.4 test suite fails #243