Improve bash script error handling and portability#836
Merged
hogashi merged 3 commits intonpmscriptjqfrom Feb 17, 2026
Merged
Conversation
…angs Co-authored-by: hogashi <12870472+hogashi@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Convert npm script to bash script
Improve bash script error handling and portability
Feb 17, 2026
hogashi
reviewed
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bash scripts created in this PR lacked proper error handling and used non-portable shebangs. Scripts would fail silently or with cryptic errors when dependencies were missing or files didn't exist.
Changes
Error handling:
set -euo pipefailto all scriptsjq,zip)Portability:
#!/usr/bin/bashto#!/usr/bin/env bash${1:-}patternCode quality:
read -rinstead ofread)*.zipto.gitignoreto exclude build artifactsAll scripts now fail fast with clear error messages when preconditions aren't met.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.