Skip to content

Comments

chore: Rebase CDK pipeline version 2.9#10

Open
hojulian wants to merge 622 commits intohojulian:mainfrom
cdklabs:main
Open

chore: Rebase CDK pipeline version 2.9#10
hojulian wants to merge 622 commits intohojulian:mainfrom
cdklabs:main

Conversation

@hojulian
Copy link
Owner

Rebases the CDK pipeline version 2.9

@hojulian hojulian changed the title Rebase CDK pipeline version 2.9 chore: Rebase CDK pipeline version 2.9 Feb 26, 2024
@watermelon-copilot-for-code-review
Copy link

watermelon-copilot-for-code-review bot commented Feb 29, 2024

Watermelon AI Summary

ErrorError: Request failed with status code 429

GitHub PRs

cdk-pipelines-github is an open repo and Watermelon will serve it for free.
🍉🫶
Have you starred Watermelon?

README.md Outdated
- [Waves for Parallel Builds](#waves-for-parallel-builds)
- [Manual Approval Step](#manual-approval-step)
- [Pipeline YAML Comments](#pipeline-yaml-comments)
- [Common Configuration for Docker Asset Publishing Steps](#common-configuration-for-docker-asset-publishing)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR contains leftover multi-line comments. Please review or remove them.

- name: Install
run: npm install --no-save cdk-assets
- name: Authenticate Via GitHub Secrets
uses: aws-actions/configure-aws-credentials@v1-node16

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR contains leftover multi-line comments. Please review or remove them.

* found in your GitHub Secrets under these default keys.
*/
public static dockerHub(creds: DockerHubCredentialSecrets = {}): DockerCredential {
const username = creds.usernameKey ?? 'DOCKERHUB_USERNAME';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR contains leftover multi-line comments. Please review or remove them.

API.md Outdated
- [Waves for Parallel Builds](#waves-for-parallel-builds)
- [Manual Approval Step](#manual-approval-step)
- [Pipeline YAML Comments](#pipeline-yaml-comments)
- [Common Configuration for Docker Asset Publishing Steps](#common-configuration-for-docker-asset-publishing)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR contains leftover multi-line comments. Please review or remove them.

const CDKOUT_ARTIFACT = 'cdk.out';
const ASSET_HASH_NAME = 'asset-hash';

/**

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR contains leftover multi-line comments. Please review or remove them.

README.md Outdated
- [Waves for Parallel Builds](#waves-for-parallel-builds)
- [Manual Approval Step](#manual-approval-step)
- [Pipeline YAML Comments](#pipeline-yaml-comments)
- [Common Configuration for Docker Asset Publishing Steps](#common-configuration-for-docker-asset-publishing)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR contains leftover multi-line comments. Please review or remove them.

const CDKOUT_ARTIFACT = 'cdk.out';
const ASSET_HASH_NAME = 'asset-hash';

/**

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR contains leftover multi-line comments. Please review or remove them.

* found in your GitHub Secrets under these default keys.
*/
public static dockerHub(creds: DockerHubCredentialSecrets = {}): DockerCredential {
const username = creds.usernameKey ?? 'DOCKERHUB_USERNAME';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR contains leftover multi-line comments. Please review or remove them.

API.md Outdated
- [Waves for Parallel Builds](#waves-for-parallel-builds)
- [Manual Approval Step](#manual-approval-step)
- [Pipeline YAML Comments](#pipeline-yaml-comments)
- [Common Configuration for Docker Asset Publishing Steps](#common-configuration-for-docker-asset-publishing)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR contains leftover multi-line comments. Please review or remove them.

image: alpine
steps:
- name: Checkout
uses: actions/checkout@v3

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR contains leftover multi-line comments. Please review or remove them.

API.md Outdated
- [Waves for Parallel Builds](#waves-for-parallel-builds)
- [Manual Approval Step](#manual-approval-step)
- [Pipeline YAML Comments](#pipeline-yaml-comments)
- [Common Configuration for Docker Asset Publishing Steps](#common-configuration-for-docker-asset-publishing)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR contains leftover multi-line comments. Please review or remove them.

image: alpine
steps:
- name: Checkout
uses: actions/checkout@v3

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR contains leftover multi-line comments. Please review or remove them.

* found in your GitHub Secrets under these default keys.
*/
public static dockerHub(creds: DockerHubCredentialSecrets = {}): DockerCredential {
const username = creds.usernameKey ?? 'DOCKERHUB_USERNAME';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR contains leftover multi-line comments. Please review or remove them.

README.md Outdated
- [Waves for Parallel Builds](#waves-for-parallel-builds)
- [Manual Approval Step](#manual-approval-step)
- [Pipeline YAML Comments](#pipeline-yaml-comments)
- [Common Configuration for Docker Asset Publishing Steps](#common-configuration-for-docker-asset-publishing)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR contains leftover multi-line comments. Please review or remove them.

const CDKOUT_ARTIFACT = 'cdk.out';
const ASSET_HASH_NAME = 'asset-hash';

/**

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR contains leftover multi-line comments. Please review or remove them.

README.md Outdated
- [Waves for Parallel Builds](#waves-for-parallel-builds)
- [Manual Approval Step](#manual-approval-step)
- [Pipeline YAML Comments](#pipeline-yaml-comments)
- [Common Configuration for Docker Asset Publishing Steps](#common-configuration-for-docker-asset-publishing)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR contains leftover multi-line comments. Please review or remove them.

const CDKOUT_ARTIFACT = 'cdk.out';
const ASSET_HASH_NAME = 'asset-hash';

/**

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR contains leftover multi-line comments. Please review or remove them.

* found in your GitHub Secrets under these default keys.
*/
public static dockerHub(creds: DockerHubCredentialSecrets = {}): DockerCredential {
const username = creds.usernameKey ?? 'DOCKERHUB_USERNAME';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR contains leftover multi-line comments. Please review or remove them.

image: alpine
steps:
- name: Checkout
uses: actions/checkout@v3

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR contains leftover multi-line comments. Please review or remove them.

API.md Outdated
- [Waves for Parallel Builds](#waves-for-parallel-builds)
- [Manual Approval Step](#manual-approval-step)
- [Pipeline YAML Comments](#pipeline-yaml-comments)
- [Common Configuration for Docker Asset Publishing Steps](#common-configuration-for-docker-asset-publishing)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR contains leftover multi-line comments. Please review or remove them.

API.md Outdated
- [Waves for Parallel Builds](#waves-for-parallel-builds)
- [Manual Approval Step](#manual-approval-step)
- [Pipeline YAML Comments](#pipeline-yaml-comments)
- [Common Configuration for Docker Asset Publishing Steps](#common-configuration-for-docker-asset-publishing)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR contains leftover multi-line comments. Please review or remove them.

README.md Outdated
- [Waves for Parallel Builds](#waves-for-parallel-builds)
- [Manual Approval Step](#manual-approval-step)
- [Pipeline YAML Comments](#pipeline-yaml-comments)
- [Common Configuration for Docker Asset Publishing Steps](#common-configuration-for-docker-asset-publishing)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR contains leftover multi-line comments. Please review or remove them.

API.md Outdated
- [Waves for Parallel Builds](#waves-for-parallel-builds)
- [Manual Approval Step](#manual-approval-step)
- [Pipeline YAML Comments](#pipeline-yaml-comments)
- [Common Configuration for Docker Asset Publishing Steps](#common-configuration-for-docker-asset-publishing)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR contains leftover multi-line comments. Please review or remove them.

const CDKOUT_ARTIFACT = 'cdk.out';
const ASSET_HASH_NAME = 'asset-hash';

/**

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR contains leftover multi-line comments. Please review or remove them.

* found in your GitHub Secrets under these default keys.
*/
public static dockerHub(creds: DockerHubCredentialSecrets = {}): DockerCredential {
const username = creds.usernameKey ?? 'DOCKERHUB_USERNAME';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR contains leftover multi-line comments. Please review or remove them.

image: alpine
steps:
- name: Checkout
uses: actions/checkout@v3

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR contains leftover multi-line comments. Please review or remove them.

const CDKOUT_ARTIFACT = 'cdk.out';
const ASSET_HASH_NAME = 'asset-hash';

/**

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR contains leftover multi-line comments. Please review or remove them.

API.md Outdated
- [Waves for Parallel Builds](#waves-for-parallel-builds)
- [Manual Approval Step](#manual-approval-step)
- [Pipeline YAML Comments](#pipeline-yaml-comments)
- [Common Configuration for Docker Asset Publishing Steps](#common-configuration-for-docker-asset-publishing)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR contains leftover multi-line comments. Please review or remove them.

pwrmiller and others added 30 commits September 4, 2025 09:34
this reflects the actual purpose of the parameter
Upgrades project dependencies. See details in [workflow run].

[Workflow Run]: https://github.com/cdklabs/cdk-pipelines-github/actions/runs/17559826852

------

*Automatically created by projen via the "upgrade-dev-deps-main" workflow*

Signed-off-by: github-actions <github-actions@github.com>
…-main

chore(deps): upgrade dev dependencies
feat!: cdkCliVersion parameter renamed to cdkAssetsVersion
Upgrades project dependencies. See details in [workflow run].

[Workflow Run]: https://github.com/cdklabs/cdk-pipelines-github/actions/runs/17742314191

------

*Automatically created by projen via the "upgrade-dev-deps-main" workflow*

Signed-off-by: github-actions <github-actions@github.com>
Co-authored-by: github-actions <github-actions@github.com>
Upgrades project dependencies. See details in [workflow run].

[Workflow Run]: https://github.com/cdklabs/cdk-pipelines-github/actions/runs/17924234049

------

*Automatically created by projen via the "upgrade-dev-deps-main" workflow*

Signed-off-by: github-actions <github-actions@github.com>
Co-authored-by: github-actions <github-actions@github.com>
Upgrades project dependencies. See details in [workflow run].

[Workflow Run]: https://github.com/cdklabs/cdk-pipelines-github/actions/runs/18106254953

------

*Automatically created by projen via the "upgrade-dev-deps-main" workflow*

Signed-off-by: github-actions <github-actions@github.com>
Co-authored-by: github-actions <github-actions@github.com>
Upgrades project dependencies. See details in [workflow run].

[Workflow Run]: https://github.com/cdklabs/cdk-pipelines-github/actions/runs/18290064829

------

*Automatically created by projen via the "upgrade-dev-deps-main" workflow*

Signed-off-by: github-actions <github-actions@github.com>
Co-authored-by: github-actions <github-actions@github.com>
Upgrades project dependencies. See details in [workflow run].

[Workflow Run]: https://github.com/cdklabs/cdk-pipelines-github/actions/runs/18474360028

------

*Automatically created by projen via the "upgrade-dev-deps-main" workflow*

Signed-off-by: github-actions <github-actions@github.com>
Co-authored-by: github-actions <github-actions@github.com>
Upgrades project dependencies. See details in [workflow run].

[Workflow Run]: https://github.com/cdklabs/cdk-pipelines-github/actions/runs/18660726345

------

*Automatically created by projen via the "upgrade-dev-deps-main" workflow*

Signed-off-by: github-actions <github-actions@github.com>
Co-authored-by: github-actions <github-actions@github.com>
Upgrades project dependencies. See details in [workflow run].

[Workflow Run]: https://github.com/cdklabs/cdk-pipelines-github/actions/runs/18753799951

------

*Automatically created by projen via the "upgrade-dev-deps-main" workflow*

Signed-off-by: github-actions <github-actions@github.com>
Co-authored-by: github-actions <github-actions@github.com>
Upgrades project dependencies. See details in [workflow run].

[Workflow Run]: https://github.com/cdklabs/cdk-pipelines-github/actions/runs/18755169737

------

*Automatically created by projen via the "upgrade-cdklabs-projen-project-types-main" workflow*

Signed-off-by: github-actions <github-actions@github.com>
Co-authored-by: github-actions <github-actions@github.com>
Upgrades project dependencies. See details in [workflow run].

[Workflow Run]: https://github.com/cdklabs/cdk-pipelines-github/actions/runs/18857249054

------

*Automatically created by projen via the "upgrade-dev-deps-main" workflow*

Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* chore(deps): upgrade dev dependencies

Upgrades project dependencies. See details in [workflow run].

[Workflow Run]: https://github.com/cdklabs/cdk-pipelines-github/actions/runs/19050769731

------

*Automatically created by projen via the "upgrade-dev-deps-main" workflow*

Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* chore: self mutation

Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

---------

Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Upgrades project dependencies. See details in [workflow run].

[Workflow Run]: https://github.com/cdklabs/cdk-pipelines-github/actions/runs/19247610582

------

*Automatically created by projen via the "upgrade-dev-deps-main" workflow*

Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Upgrades project dependencies. See details in [workflow run].

[Workflow Run]: https://github.com/cdklabs/cdk-pipelines-github/actions/runs/19446138591

------

*Automatically created by projen via the "upgrade-dev-deps-main" workflow*

Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Upgrades project dependencies. See details in [workflow run].

[Workflow Run]: https://github.com/cdklabs/cdk-pipelines-github/actions/runs/19650766141

------

*Automatically created by projen via the "upgrade-dev-deps-main" workflow*

Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Upgrades project dependencies. See details in [workflow run].

[Workflow Run]: https://github.com/cdklabs/cdk-pipelines-github/actions/runs/19832576398

------

*Automatically created by projen via the "upgrade-main" workflow*

Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Upgrades project dependencies. See details in [workflow run].

[Workflow Run]: https://github.com/cdklabs/cdk-pipelines-github/actions/runs/19839080747

------

*Automatically created by projen via the "upgrade-dev-deps-main" workflow*

Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Upgrades project dependencies. See details in [workflow run].

[Workflow Run]: https://github.com/cdklabs/cdk-pipelines-github/actions/runs/20044343571

------

*Automatically created by projen via the "upgrade-dev-deps-main" workflow*

Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Upgrades project dependencies. See details in [workflow run].

[Workflow Run]: https://github.com/cdklabs/cdk-pipelines-github/actions/runs/20249025169

------

*Automatically created by projen via the "upgrade-dev-deps-main" workflow*

Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Upgrades project dependencies. See details in [workflow run].

[Workflow Run]: https://github.com/cdklabs/cdk-pipelines-github/actions/runs/20445201344

------

*Automatically created by projen via the "upgrade-dev-deps-main" workflow*

Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Upgrades project dependencies. See details in [workflow run].

[Workflow Run]: https://github.com/cdklabs/cdk-pipelines-github/actions/runs/20583694732

------

*Automatically created by projen via the "upgrade-dev-deps-main" workflow*

Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Upgrades project dependencies. See details in [workflow run].

[Workflow Run]: https://github.com/cdklabs/cdk-pipelines-github/actions/runs/20730596693

------

*Automatically created by projen via the "upgrade-dev-deps-main" workflow*

Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Upgrades project dependencies. See details in [workflow run].

[Workflow Run]: https://github.com/cdklabs/cdk-pipelines-github/actions/runs/20936636230

------

*Automatically created by projen via the "upgrade-dev-deps-main" workflow*

Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Upgrades project dependencies. See details in [workflow run].

[Workflow Run]: https://github.com/cdklabs/cdk-pipelines-github/actions/runs/21152664435

------

*Automatically created by projen via the "upgrade-dev-deps-main" workflow*

Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Upgrades project dependencies. See details in [workflow run].

[Workflow Run]: https://github.com/cdklabs/cdk-pipelines-github/actions/runs/21375778737

------

*Automatically created by projen via the "upgrade-dev-deps-main" workflow*

Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Upgrades project dependencies. See details in [workflow run].

[Workflow Run]: https://github.com/cdklabs/cdk-pipelines-github/actions/runs/21608250996

------

*Automatically created by projen via the "upgrade-dev-deps-main" workflow*

Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Upgrades project dependencies. See details in [workflow run].

[Workflow Run]: https://github.com/cdklabs/cdk-pipelines-github/actions/runs/21842844887

------

*Automatically created by projen via the "upgrade-dev-deps-main" workflow*

Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Upgrades project dependencies. See details in [workflow run].

[Workflow Run]: https://github.com/cdklabs/cdk-pipelines-github/actions/runs/22097494790

------

*Automatically created by projen via the "upgrade-dev-deps-main" workflow*

Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants