Remove September 1st from Slovak holidays #288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Tests for the sk region are passing However, I do get some failed test from the global ones, but they do not seem to be connected to my change |
|
Hello, any updates on this? We use this gem and we need this update to do some processing related to Slovak working calendar. |
|
@ppeble Could this be merged and released under a new version, please? |
|
@ppeble Can this be merged and released, please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, a new law was adopted in Slovakia removing the September 1st from public holidays. This law is valid from 2024 https://www.slov-lex.sk/pravne-predpisy/SK/ZZ/1993/241/
The wikipedia source mentioned in sk.yaml is already updated with this change.
