-
Notifications
You must be signed in to change notification settings - Fork 39
isis: publish spb capability #102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
08def3a to
74cd379
Compare
rwestphal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fliqqs Amazing work! Please rebase to fix the merge conflict (I changed the CI to use a different spell checker) and I'll merge this.
9d44a2f to
fd29f29
Compare
|
Addressed the review comments looks like the new spell check is not happy with ECT 😂 |
rwestphal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fliqqs Thank you for the update!
Regarding the spell checker failure, please add an exception for "ECT" in _typos.toml. That should fix the issue.
We could configure the spell checker to ignore uppercase words, as most of the time they are valid acronyms. But that would probably be an overkill, as cases like this should be a rare occurrence. As of now, we only have three exceptions in the typos dictionary, which is sufficient for the entire codebase. typos does a much better job than cargo-spellcheck at avoiding false positives, but it's still not perfect :(
On a separate note, you could squash the third commit into the second one, since ideally every commit should compile and pass all tests. This helps when using git-bisect.
include SPBM Service Identifier stlv extend yang configuration and state augments originate mt cap tlvs in lsps
8d49b34 to
a7b5983
Compare
Initial extension to add SPB NLPID capability to Hello
Implement MT capability TLV and SPB service STLV's