Skip to content

Conversation

@fliqqs
Copy link
Member

@fliqqs fliqqs commented Dec 30, 2025

Initial extension to add SPB NLPID capability to Hello

Implement MT capability TLV and SPB service STLV's

@fliqqs fliqqs requested a review from rwestphal December 30, 2025 02:01
@fliqqs fliqqs force-pushed the shortest-path-bridging branch 2 times, most recently from 08def3a to 74cd379 Compare January 4, 2026 06:27
Copy link
Member

@rwestphal rwestphal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fliqqs Amazing work! Please rebase to fix the merge conflict (I changed the CI to use a different spell checker) and I'll merge this.

@fliqqs fliqqs force-pushed the shortest-path-bridging branch 2 times, most recently from 9d44a2f to fd29f29 Compare January 5, 2026 03:41
@fliqqs
Copy link
Member Author

fliqqs commented Jan 5, 2026

Addressed the review comments looks like the new spell check is not happy with ECT 😂

Copy link
Member

@rwestphal rwestphal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fliqqs Thank you for the update!

Regarding the spell checker failure, please add an exception for "ECT" in _typos.toml. That should fix the issue.

We could configure the spell checker to ignore uppercase words, as most of the time they are valid acronyms. But that would probably be an overkill, as cases like this should be a rare occurrence. As of now, we only have three exceptions in the typos dictionary, which is sufficient for the entire codebase. typos does a much better job than cargo-spellcheck at avoiding false positives, but it's still not perfect :(

On a separate note, you could squash the third commit into the second one, since ideally every commit should compile and pass all tests. This helps when using git-bisect.

fliqqs added 3 commits January 9, 2026 18:01
include SPBM Service Identifier stlv

extend yang configuration and state augments

originate mt cap tlvs in lsps
@fliqqs fliqqs force-pushed the shortest-path-bridging branch from 8d49b34 to a7b5983 Compare January 9, 2026 23:02
@rwestphal rwestphal merged commit 5eb6e64 into holo-routing:master Jan 10, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants