Alpine: Add 3.23, drop 3.20 #339
Conversation
sairon
left a comment
sairon
left a comment
There was a problem hiding this comment.
In general looks good, let's just extract the devcontainer changes to a separate PR for the reasons discussed below.
| ARG VARIANT="3.21" | ||
| # [Choice] Alpine version: 3.21, 3.22, 3.23 | ||
| ARG VARIANT="3.22" | ||
| FROM mcr.microsoft.com/devcontainers/base:0-alpine-${VARIANT} |
There was a problem hiding this comment.
There is no such image, it's mcr.microsoft.com/devcontainers/base:1-alpine-3.22 for Alpine v3.22 (the base image version was bumped), see: https://github.com/devcontainers/images/blob/main/src/base-alpine/README.md
Maybe we could use plain base:alpine-${VARIANT}, as we don't pin to specific Alpine builds anyway? Also, for v3.23 there is no devcontainer yet, so the comment is misleading.
In general I'd suggest to move this out of this PR and make a separate PR for the devcontainer changes.
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
|
Also, please extract the changes in the Python base images from this PR. That way we can make the CI for those changes pass - currently they don't build as the base image is not published yet. Feel free to do it before this PR is merged, I'll make sure to run the workflow when it's ready. |
|
@sairon thanks for the review! I made the changes. |
sairon
left a comment
sairon
left a comment
There was a problem hiding this comment.
Looks good, thank you! Will you follow up with the Python base images update?
2 participants
I hope I did everything correct to get alpine 3.23 added here.