Fix: simplification for disjunctions#75
Merged
KenSakayori merged 3 commits intomasterfrom Oct 31, 2025
Merged
Conversation
Since bin_simpl is more fundamental than conj_simpl, the document now explains bin_simpl
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #74.
As described in #74, the fix is one line, but this PR makes the following additional changes
(or (and A B) (and A B C)), which wasn't working correctly.check_simplI did 2 partly because I wanted to do 1, but also because the behavior of
bin_simplwasn't that clear to me when I first read the code. I did 3 because I was unaware of this option, and this option is useful for debugging. In fact, it can catch the bug of #74.