Open
Conversation
The deleted options are the ones that are not supported by the current rethfl. Moreover, it doesn't seem to be a good design to support these options.
Now - stop_if_tractable - stop_if_intractable are removed. Instead there's a boolean flag named rethfl_remove_disjunction
This extra information was reported by a modified version of rethfl and we do not need that anymore
Current rethfly does not have the option --tractable-check-only, so we should not invoke rethfl for this. Moreover, this functionallity is already provided by the hfl library
The other cases always shows debug context, so to be consistent we should show it in this case as well
Member
Author
|
rebased on top of master |
KenSakayori
commented
Aug 14, 2025
| ) | ||
| ] else []) | ||
| @ (if solve_options.remove_disjunctions || solve_options.only_remove_disjunctions then [ | ||
| (* try both remove_disjunction and ECHC (i.e. pc sat)*) |
|
|
||
| module type BackendSolver = sig | ||
| val run : options -> debug_context -> Hfl.Type.simple_ty Hflz.hes -> bool -> bool -> bool -> bool -> (Status.t * extra_status option) Deferred.t | ||
| val run : options -> debug_context -> Hfl.Type.simple_ty Hflz.hes -> bool -> bool -> bool -> Status.t Deferred.t |
Member
Author
There was a problem hiding this comment.
It might be better to add all these options to options
Comment on lines
929
to
931
| match ex with | ||
| | Some ExStatusIntractable -> (s, {d with solved_by = "pcsat"}) | ||
| | _ -> (s, d) |
Member
Author
There was a problem hiding this comment.
We should check tractability and if it's intractable, then we should invoke pcsat
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was hard to run muhfl outside the artifact image because muhfl relied on a variant of rethfl that was also packed in the artifact. This PR allows us to use the latest ReTHFL as the backend solver.
At least, I was able to execute the following command without any problem.
Note that I had to use
--only-remove-disjunctionsbecause I don't have PCSat installed, and I'm not sure if the current rethfl works fine with PCSat.I haven't checked whether there is any regression compared to the artifact. This is hard to test. Anyway, even if there is the fact that the tool is working outside the image is a milestone, and hence, I'm going to merge this.
I haven't changed the README nor the Docker file. I don't know if I'll add those changes to this PR or do them later.
This PR builds on top of #6.