Merged
Conversation
KenSakayori
commented
Jan 1, 2025
| | Bool x when x -> Fmt.string ppf "tt" | ||
| | Bool _ -> Fmt.string ppf "ff" | ||
| | Var x -> Fmt.string ppf @@ Id.to_string x | ||
| | Or (x, y, _, _) -> |
Member
Author
There was a problem hiding this comment.
I don't know why And and Or are asymmetric, but I followed the original implementation.
KenSakayori
commented
Jan 1, 2025
| print_rtype hes_rule.var.ty; | ||
| print_newline (); | ||
| print_hes xs | ||
| let pp_env ppf env = |
Member
Author
There was a problem hiding this comment.
The pretty printer that prints type bindings now takes type environments rather than hes as the argument.
This is because hes might be cut off in the type annotation mode.
Because of this print_derived_refinement_type is also modified
Member
Author
|
Merged as @moratorium08 told me it's okay to do so. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the output/logging feature of ReTHFL.
Currently, ReTHFL outputs lots of debug information to stdout.
For example,
After the change, the output becomes
With
--show-refinement, it is as followsAll the information the has been hidden can be shown by adding the verbose flag
-v(with a better formatting).It is also possible to specify the module the user want to log.
As a byproduct, this PR implements various pretty printers.