Open
Conversation
These were inferred, but the nightly compiler now has a warning: ``` warning: lifetime flowing from input to output with different syntax can be confusing ```
This warning advises rewriting many places where we check if there is at least 1 byte in a read buffer as an is_empty() check, which seems like bad advice here.
Alternative solutions include switching to a glob import, or removing the unused imports entirely.
When this doc comment was first written in commit 2d67eca, there was some unsafe-- but this is no longer the case. Closes issue hsivonen#72
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR cleans up the clippy lints, allowing some and addressing others.
I am developing on x86_64 Windows, so there's a chance I've overlooked lints in platform-specific places such as the ARM NEON code.
I have intentionally left the following 6 clippy lints unsolved, as they are addressed in sibling PR #121. (click to expand)
(warning and error are repeated 3 times each)
Obsoletes open PR #78 ("Fix clippy lints") from 3 years ago.