Skip to content

Comments

Plot improvements#3

Merged
breznak merged 5 commits intomasterfrom
plot_community
Jul 24, 2019
Merged

Plot improvements#3
breznak merged 5 commits intomasterfrom
plot_community

Conversation

@breznak
Copy link
Member

@breznak breznak commented Jul 24, 2019

community version of numenta#342

  • makes plots work out of the box (installs plotly requirement)
  • include data in package, otherwise plot was broken with invalid paths
  • additional fixes for plotly API changes (not part of Numenta PR, should be added there too)

breznak added 5 commits July 24, 2019 12:06
required for scripts/plot.py
the plot was failing due to non-existing argument, just removed
@breznak breznak added the bug Something isn't working label Jul 24, 2019
@breznak breznak self-assigned this Jul 24, 2019
Copy link
Collaborator

@ctrl-z-9000-times ctrl-z-9000-times left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@breznak breznak merged commit c4d1e20 into master Jul 24, 2019
@breznak breznak deleted the plot_community branch July 24, 2019 13:50
@breznak
Copy link
Member Author

breznak commented Jul 24, 2019

Thank you for reviewing, David!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants