Undo panda vis and merge fix spatial#43
Closed
Zbysekz wants to merge 40 commits intohtm-community:masterfrom
Closed
Undo panda vis and merge fix spatial#43Zbysekz wants to merge 40 commits intohtm-community:masterfrom
Zbysekz wants to merge 40 commits intohtm-community:masterfrom
Conversation
This reverts commit 354a025.
which is "fake" and non-biological, not HTM related. Unfortunately, with the current settings the code affected the results the most.
This reverts commit 09f2839.
optimized params
…fixing_spatial_anomaly
Tuning SP params
now the params are directly comparable to Numenta's.
use original numenta params
results with SP w numActiveColumnsPerInhArea
(temporarily) reintroducing spatial anomaly in HTMcore detector
minor fix to enable "reset"
optimization results
…ementation" This reverts commit e34e6f4.
Fixing spatial anomaly
Author
|
@breznak this seems good. I will add thresholds and it should be ready |
breznak
approved these changes
Sep 15, 2020
Member
breznak
left a comment
breznak
left a comment
There was a problem hiding this comment.
The diffs in HTMcore detector were a bit hard to read, but I tried to check throuroughly and seems good to me 👍 Thanks!
breznak
reviewed
Sep 15, 2020
| "standard": 63.081419488725054 | ||
| "reward_low_FN_rate": 76.5626293570994, | ||
| "reward_low_FP_rate": 61.359926511549155, | ||
| "standard": 71.3094612770284 |
Member
There was a problem hiding this comment.
this is with the "master" of htmcore? Are the results stable, ie reasonably consistent over several runs? If so, please also bump our score table in Readme and you can move us to the 1st place! ;)
Author
There was a problem hiding this comment.
wait a second, i must push the non spatial numbers &try to build with latest htm.core
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts pandaVis for htm_core nab detector & contains changes in #15 (there was merge conflicts)