Skip to content

Comments

Fix: passing classes to store methods was removed#29

Closed
jelhan wants to merge 1 commit intohuafu:masterfrom
jelhan:fix_ember_data_V1.0.0-BETA.19
Closed

Fix: passing classes to store methods was removed#29
jelhan wants to merge 1 commit intohuafu:masterfrom
jelhan:fix_ember_data_V1.0.0-BETA.19

Conversation

@jelhan
Copy link

@jelhan jelhan commented Sep 20, 2015

Fix: passing classes to store methods was removed in ember data V1.0.0-BETA.19
http://emberjs.com/blog/2015/06/05/ember-data-1-0-beta-19-released.html#toc_breaking-changes

@jelhan
Copy link
Author

jelhan commented Sep 20, 2015

I'm not sure if all this modelFor(modelName) lookup could be removed. Perhaps I missed one point but it looks like only typeKey property of model class is used which is actually modelName.

I tested against these fork https://github.com/heartsentwined/ember-data-sails because of #26

@jelhan
Copy link
Author

jelhan commented Sep 20, 2015

Fix is also included in #27. Closing in favor of that one.

@jelhan jelhan closed this Sep 20, 2015
@jelhan jelhan reopened this Sep 20, 2015
@jelhan
Copy link
Author

jelhan commented Sep 20, 2015

Reopened since #27 seems to be broken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant