Migrate the code to the new Ember 2.0 newSerializer code base & Errors fix#30
Open
danshapir wants to merge 5 commits intohuafu:masterfrom
Open
Migrate the code to the new Ember 2.0 newSerializer code base & Errors fix#30danshapir wants to merge 5 commits intohuafu:masterfrom
danshapir wants to merge 5 commits intohuafu:masterfrom
Conversation
* Fix the errors checks - was checking for errors field instead of just using the isErrorObject
Author
|
Anyone here? :) |
|
Does this work with Ember data 2.x? |
Author
|
No idea. Been a while, check and let me know. I'll help in fixing it if needed. |
|
@danshapir I would like to help. This is a good module. |
|
Well, tested and this is not working. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've migrated the code to work with Ember 2.0 and the new Ember Data (normalizeResponse instead of all the extract hooks).
I've also fixes the errors handling from the Sails server that wasn't working - no .errors property is returned, only an .error. So I moved the code to use isErrorObject function you've already implemented.
I've also updated us to the latest ember-cli and ember versions