Open
Conversation
…of power fix the same typo also in version 2.3
st4rtr3ck
force-pushed
the
fix-physical-unit-typo
branch
from
2bd9d1c to
a17469e
Compare
Author
|
@oicp-moderator I rebased and squashed my commits for a clean PR. Now we only need an approval and a merge to remove this confusing typo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The protocol wrongly claims that
MaximumProductChargingPoweris measured in kilowatt-hours, but physics dictates that that is a unit of energy and power is measured rather in kilowatts, i.e.kW. Fixing this typo.