Design System Add Unique Item Count - Filter Form#2093
Draft
saaivignesh20 wants to merge 1 commit intodevelopfrom
Draft
Design System Add Unique Item Count - Filter Form#2093saaivignesh20 wants to merge 1 commit intodevelopfrom
saaivignesh20 wants to merge 1 commit intodevelopfrom
Conversation
|
View your CI Pipeline Execution ↗ for commit 3dc9272
☁️ Nx Cloud last updated this comment at |
🚀 Preview Deploy Report✅ Successfully deployed preview here |
axdanbol
requested changes
Jan 30, 2026
| <div class="label"> | ||
| {{ action() }} | ||
| </div> | ||
| <div class="count" hraPlainTooltip="Number of unique items per filter category"> |
Contributor
There was a problem hiding this comment.
The total count should be outside of the button
| {{ action() }} | ||
| </div> | ||
| <div class="count" hraPlainTooltip="Number of unique items per filter category"> | ||
| {{ filterTotalCount()?.toLocaleString() }} |
Contributor
There was a problem hiding this comment.
Suggested change
| {{ filterTotalCount()?.toLocaleString() }} | |
| {{ filterTotalCount() | number }} |
| } | ||
| } | ||
|
|
||
| .top-row .category-button { |
Contributor
There was a problem hiding this comment.
Always nest styles in the top level :host block
| } | ||
|
|
||
| .top-row .category-button { | ||
| ::ng-deep .mdc-button__label { |
Contributor
There was a problem hiding this comment.
Remove once you've moved the count outside the button
| readonly action = input.required<string>(); | ||
|
|
||
| /** Total count of filter options in the category */ | ||
| readonly filterTotalCount = input<number | undefined>(); |
Contributor
There was a problem hiding this comment.
Suggested change
| readonly filterTotalCount = input<number | undefined>(); | |
| readonly totalCount = input<number>(); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request resolves the following GitHub issue: