Skip to content

Conversation

@kevin-schmid
Copy link

Changed the App model to use the more generic PackageItemInfo. Everything else is done in the AppManager.

I used this stackoverflow post to add the getAppsThroughPackages method which returns a list that is combined with your queryIntentActivities lookup. I also had to change the startApp method to be able to launch intents without leanback.

One open issue: I can't load a banner, so I use the icon which looks kinda ugly. I changed the behaviour that if no banner is found the icon is always used.

@hugegreenbug
Copy link
Owner

I tried this patch out. I had the following issues apart from the one you mentioned above:

  • Some apps displayed are not launchable and will cause launchy to crash since the intent is null
  • Some apps are returned in both: getAppsThroughPackages and queryIntentActivities. In this case, the we should prefer queryIntentActivities. An example of this was the TED app.
  • Some apps' icons are cut off and will need some scaling before being displayed
  • If apps do not have a banner, we should make a background around the icon so it looks more like the others
  • if apps do not have a banner, should there be a text label? Since the default icon is generic we won't know the difference between them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants