Feat: adding is_training argument to implement KV cache only during inference#93
Closed
adityavipradas wants to merge 2 commits intohuggingface:mainfrom
Closed
Feat: adding is_training argument to implement KV cache only during inference#93adityavipradas wants to merge 2 commits intohuggingface:mainfrom
adityavipradas wants to merge 2 commits intohuggingface:mainfrom
Conversation
added is_training argument to cache KV only during inference. The argument is added in LanguageModel(), LanguageModelBlock(), and LanguageModelGroupedQueryAttention() functions
added is_training argument
Collaborator
|
if it helps, you should note that the |
Author
|
Makes sense. But I observed using self.training will result in populating KV cache during validation as well. Instead, I used torch.is_grad_enabled() which is set to False during validation and inference & True during training. Created a new PR here: #94 |
Author
|
Closing this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolving issue #92