Update to SIGINT handler PR. #599
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There have been many dead code left in xet-core due to `#![allow(dead_code)]` at a couple of places. This PR removes them and fix the corresponding linting errors. No functionality change.
The repo scanner migration services calls xet-core with tracing subscriber set to logging at `INFO` level. As a result, xet-core has been too chatty for repo scanner because we log at `INFO` level at many places as we wanted to log more info in hf-xet to help diagnose problems. This PR employs a build feature `elevated_information_level` which is enabled only for hf-xet, such that the information we want to log in hf-xet are still emitted at `INFO` level, but for others emitted at `DEBUG` level, so not to clutter the repo scanner log.
- Remove dependencies from Cargo.toml files that are not used. - Move dependencies directly referencing crates.io from crate level Cargo.toml to the workspace Cargo.toml. - Fix using RemoteClient in WASM: AdaptiveConcurrencyController uses `tokio::time::Instant` which wraps `std::time::Instant` and is not available in WASM. - Add [cargo-machete](https://github.com/bnjbvr/cargo-machete) to CI to check unused dependencies. No functionality change.
…#591) This function adds get_file_term_data and get_reconstruction to the Client interface, including adding those functions to the LocalClient. It also rearranges some things in the RemoteClient struct to call the methods from there. This is the first step in a larger effort to separate out the file writer methods from the RemoteClient class in order to allow for more thorough testing and simulation using the LocalClient backend.
Simplify windows sigint handler.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR against #587 to simplify signal handling.