Make segmenter load dictionary using github.com/wangkuiyi/fs #19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Hui,
Thank you for this great work of Chinese tokenizer!
I am open sourcing a distributed machine learning system, where thousands of processes using your tokenizer run on hundreds of computers. To make it easy for those processes to load the dictionary, it would be great if we can load the dictionary from HDFS. Also, loading from local filesystem is important for testing purpose. So I wrote
github.com/wangkuiyi/fsand propose this two-line change to enablesegoloading its dictionary from HDFS and local filesystem transparently.I think an alternative solution to support transparency between HDFS and local filesystem is that
segoload the dictionary from anio.Readerinterface, so the caller can open whatever file streams and pass it tosego. This alternation doesn't relysegoonfs. What do you think about this? I am happy with either solution!Thanks,
Yi