24 cleanup new entities #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor methods and improve docstrings for clarity.
Updated type hints and improved error handling in helper methods.
Refactor types.py to introduce SI unit types and improve normalization logic. Update various dimensioned types to inherit from the new SI base class, enhancing unit handling and conversions.
Updated method names in documentation and code to reflect changes from 'initialize_from_data' to 'from_data' and 'initialize_from_session' to 'from_session'. Adjusted API calls to use the new method names for creating entity instances.
Removed the api_instance fixture from test_exceptions.py.
Removed a test case for station_detail with all arguments filled and added a test case for invalid parameters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copied over from VSCode due to github authentication issues