Added admin notice when Imagick is not installed #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roborourke
reviewed
Sep 7, 2020
Contributor
roborourke
left a comment
roborourke
left a comment
There was a problem hiding this comment.
Should JPEG\data_for_file() return an error when the module is not available?
I think we should just avoid bootstrapping the plugin at all apart from the admin notice in this case.
WP CLI just displays an standard The site is experiencing technical difficulties error when Imagick is not installed. It took me a while to realize what was the problem. Should we also add an error message for WP CLI?
Yeah I reckon that'd be helpful.
Should the notice be dismissable?
I think that's not super important, you either have Imagick or you don't, if you don't then you should probably be removing or deactivating the plugin.
Co-authored-by: Robert O'Rourke <robert@o-rourke.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Imagick is needed to use this plugin, however it is not always installed.
I've added an admin notice to display an error message when the module is not available. There are certain things that could be also improved and discussed regarding this:
The site is experiencing technical difficultieserror when Imagick is not installed. It took me a while to realize what was the problem. Should we also add an error message for WP CLI?